rdblue commented on a change in pull request #1352:
URL: https://github.com/apache/iceberg/pull/1352#discussion_r475141330
##########
File path: core/src/main/java/org/apache/iceberg/DeleteFileIndex.java
##########
@@ -78,6 +82,10 @@
this.sortedDeletesByPartition = sortedDeletesByPartition;
}
+ public boolean isEmpty() {
+ return (globalDeletes == null || globalDeletes.length == 0) &&
sortedDeletesByPartition.isEmpty();
Review comment:
The reason why I didn't is that this constructor is not public. It will
only be called by tests and the builder, so I think we can be more relaxed
about validation. We know that this is never null because the builder never
calls it that way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
