Fokko commented on code in PR #1387: URL: https://github.com/apache/iceberg-python/pull/1387#discussion_r1868746609
########## mkdocs/docs/how-to-release.md: ########## @@ -130,6 +130,15 @@ Run the [`Python release` Github Action](https://github.com/apache/iceberg-pytho * Tag: Use the newly created tag. * Version: Set the `version` to `main`, as the source cannot be modified. +Or if `gh` is available, trigger the action using: + +```bash +gh workflow run python-release.yml --repo apache/iceberg-python --ref ${GIT_TAG} --field version=main +SVN_RUN_ID=$(gh run list --repo apache/iceberg-python --json databaseId -q '.[0].databaseId') Review Comment: I think this takes the latest run, would that be safe? Or should we do some more filtering ########## mkdocs/docs/how-to-release.md: ########## @@ -130,6 +130,15 @@ Run the [`Python release` Github Action](https://github.com/apache/iceberg-pytho * Tag: Use the newly created tag. * Version: Set the `version` to `main`, as the source cannot be modified. +Or if `gh` is available, trigger the action using: + +```bash +gh workflow run python-release.yml --repo apache/iceberg-python --ref ${GIT_TAG} --field version=main Review Comment: How about instead of having to trigger this manually, we could also trigger this by the tag creation. That's one of the first steps of the RC process: https://py.iceberg.apache.org/how-to-release/#create-tag This would trigger a job without having to do anything manual, similar to Iceberg-Go: https://github.com/apache/iceberg-go/blob/c1ffe04d56e31e475b52ce75fcbf16818a6e1169/.github/workflows/rc.yml#L24-L25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
