cmathiesen commented on a change in pull request #1326:
URL: https://github.com/apache/iceberg/pull/1326#discussion_r475508206
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergFilterFactory.java
##########
@@ -140,18 +137,34 @@ private static Object leafToLiteral(PredicateLeaf leaf) {
case STRING:
return leaf.getLiteralList();
case DATE:
- return leaf.getLiteralList().stream().map(value -> ((Date)
value).toLocalDate().toEpochDay())
+ return leaf.getLiteralList().stream().map(value -> dateToString((Date)
value))
.collect(Collectors.toList());
case DECIMAL:
return leaf.getLiteralList().stream()
- .map(value -> BigDecimal.valueOf(((HiveDecimalWritable)
value).doubleValue()))
+ .map(value -> hiveDecimalToBigDecimal((HiveDecimalWritable)
value))
.collect(Collectors.toList());
case TIMESTAMP:
return leaf.getLiteralList().stream()
- .map(value -> ((Timestamp) value).toInstant().getEpochSecond()
* MICROS_PER_SECOND +
- ((Timestamp) value).getNanos() /
NANOS_PER_MICROSEC).collect(Collectors.toList());
+ .map(value -> timestampToTimestampString((Timestamp) value))
Review comment:
Ah sure, thank you for explaining that, I think I misunderstood what to
do from the last comment - should hopefully be fixed now :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
