edgarRd commented on issue #1345: URL: https://github.com/apache/iceberg/issues/1345#issuecomment-679417869
While working on this I noticed that we only compute the `NameMapping` when it is set in the table properties in: https://github.com/apache/iceberg/blob/master/spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java#L577 otherwise we get `null`. As per https://github.com/apache/iceberg/pull/1167/files/eadac8d5da4f7911e4734f101c8756ee12f2aea9#diff-ea7008dc637345e7a36b5e1b5a579e13 - this will break since there's no IDs in the ORC data, so there's a couple of questions: 1. Should we have a default `NameMapping` built with the target Iceberg table schema? 2. Should we change https://github.com/apache/iceberg/pull/1167/files/eadac8d5da4f7911e4734f101c8756ee12f2aea9#diff-ea7008dc637345e7a36b5e1b5a579e13 to not fail if there's no IDs found? What do you think, @rdsr @aokolnychyi ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
