RussellSpitzer opened a new pull request #1374: URL: https://github.com/apache/iceberg/pull/1374
The core issue here was that previously when using CloseableIterable.filter The iterator generated by the wrapped Iterable would be wrapped by a Guava Iterator regardless of the wrapped iterators closable status. This means Calling Filter on an iterable would result in a CloseableIterable which generated incorrectly unclosable Iterators. To fix this we replace the Guava IterablesFilter operation with the FilterIterator class. This properly wraps the underlying closable iterator so that when we generate iterators we still get classes that can close their wrapped implementations. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
