JingsongLi commented on a change in pull request #1346:
URL: https://github.com/apache/iceberg/pull/1346#discussion_r476974613
##########
File path: flink/src/main/java/org/apache/iceberg/flink/data/FlinkOrcReader.java
##########
@@ -39,18 +39,14 @@
public class FlinkOrcReader implements OrcRowReader<RowData> {
private final OrcValueReader<?> reader;
- private FlinkOrcReader(Schema iSchema, TypeDescription readSchema) {
+ public FlinkOrcReader(Schema iSchema, TypeDescription readSchema) {
this(iSchema, readSchema, ImmutableMap.of());
}
- private FlinkOrcReader(Schema iSchema, TypeDescription readSchema,
Map<Integer, ?> idToConstant) {
+ public FlinkOrcReader(Schema iSchema, TypeDescription readSchema,
Map<Integer, ?> idToConstant) {
this.reader = OrcSchemaWithTypeVisitor.visit(iSchema, readSchema, new
ReadBuilder(idToConstant));
}
- public static OrcRowReader<RowData> buildReader(Schema schema,
TypeDescription readSchema) {
Review comment:
Because there are two constructors, so we need to have two static
helpers, I think we can use constructors directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
