smaheshwar-pltr commented on code in PR #1452:
URL: https://github.com/apache/iceberg-python/pull/1452#discussion_r1893940056
##########
pyiceberg/table/__init__.py:
##########
@@ -1632,6 +1636,67 @@ class AddFileTask:
partition_field_value: Record
+class LocationProvider(ABC):
+ """A base class for location providers, that provide data file locations
for write tasks."""
+
+ table_location: str
+ table_properties: Properties
+
+ def __init__(self, table_location: str, table_properties: Properties):
+ self.table_location = table_location
+ self.table_properties = table_properties
+
+ @abstractmethod
+ def new_data_location(self, data_file_name: str, partition_key:
Optional[PartitionKey] = None) -> str:
+ """Return a fully-qualified data file location for the given filename.
+
+ Args:
+ data_file_name (str): The name of the data file.
+ partition_key (Optional[PartitionKey]): The data file's partition
key. If None, the data is not partitioned.
+
+ Returns:
+ str: A fully-qualified location URI for the data file.
+ """
+
+
+def _import_location_provider(
+ location_provider_impl: str, table_location: str, table_properties:
Properties
+) -> Optional[LocationProvider]:
+ try:
+ path_parts = location_provider_impl.split(".")
+ if len(path_parts) < 2:
+ raise ValueError(
+ f"{TableProperties.WRITE_LOCATION_PROVIDER_IMPL} should be
full path (module.CustomLocationProvider), got: {location_provider_impl}"
+ )
+ module_name, class_name = ".".join(path_parts[:-1]), path_parts[-1]
+ module = importlib.import_module(module_name)
+ class_ = getattr(module, class_name)
Review Comment:
Hmm, wonder if we should reduce duplication between this and file IO loading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
