aokolnychyi commented on a change in pull request #1373:
URL: https://github.com/apache/iceberg/pull/1373#discussion_r477606642
##########
File path: api/src/main/java/org/apache/iceberg/catalog/Catalog.java
##########
@@ -58,9 +60,50 @@ Table createTable(
TableIdentifier identifier,
Schema schema,
PartitionSpec spec,
+ SortOrder sortOrder,
String location,
Map<String, String> properties);
+ /**
+ * Create a table.
+ *
+ * @param identifier a table identifier
+ * @param schema a schema
+ * @param spec a partition spec
+ * @param location a location for the table; leave null if unspecified
+ * @param properties a string map of table properties
+ * @return a Table instance
+ * @throws AlreadyExistsException if the table already exists
+ */
+ default Table createTable(
Review comment:
@rdsr @shardulm94 @rdblue what do you guys think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
