aokolnychyi commented on a change in pull request #1395:
URL: https://github.com/apache/iceberg/pull/1395#discussion_r478681895
##########
File path:
spark/src/main/java/org/apache/iceberg/actions/ExpireSnapshotsAction.java
##########
@@ -92,11 +92,10 @@ protected Table table() {
}
/**
- * Whether or not to use stream the expired file list to the driver. The
default (false) will use
- * collect to bring back all results to the driver at once which may be an
issue with very long file lists.
- * Set this to true to use toLocalIterator if you are running into memory
issues when collecting the list of files
- * to be deleted.
- * @param stream whether to use toLocalIterator to stream results instead of
collect.
+ * By default, all files to delete are brought to the driver at once which
may be an issue with very long file lists.
+ * Set this to true to use {@link Dataset#toLocalIterator()} if you are
running into memory issues when collecting
+ * the list of files to be deleted.
+ * @param stream whether to use {@link Dataset#toLocalIterator} to stream
results instead of {@link Dataset#collect}.
Review comment:
You are right, my bad.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
