nastra commented on code in PR #11897:
URL: https://github.com/apache/iceberg/pull/11897#discussion_r1905320421


##########
docs/docs/spark-queries.md:
##########
@@ -334,9 +334,9 @@ To show a table's current file manifests:
 SELECT * FROM prod.db.table.manifests;
 ```
 
-| path | length | partition_spec_id | added_snapshot_id | 
added_data_files_count | existing_data_files_count | deleted_data_files_count | 
partition_summaries |
-| -- | -- | -- | -- | -- | -- | -- | -- |
-| s3://.../table/metadata/45b5290b-ee61-4788-b324-b1e2735c0e10-m0.avro | 4479  
 | 0                 | 6668963634911763636 | 8                      | 0         
                | 0                        | 
[[false,null,2019-05-13,2019-05-15]] |
+| content |  path | length | partition_spec_id | added_snapshot_id | 
added_data_files_count | existing_data_files_count | deleted_data_files_count | 
added_delete_files_count | existing_delete_files_count | 
deleted_delete_files_count | partition_summaries| reference_snapshot_id |

Review Comment:
   I believe `reference_snapshot_id` only applies to `all_manifests` and not to 
the `manifests`. See 
https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/ManifestsTable.java#L31
 vs 
https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/AllManifestsTable.java#L57



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to