kevinjqliu commented on issue #1253: URL: https://github.com/apache/iceberg-python/issues/1253#issuecomment-2584974311
> The reason behind my head is, to my understanding, autocommit is still somewhat a related concept with transaction. I think its fair to ask if we consider `UpdateSchema` to be a transaction. If so, we cannot allow `autocommit` since that'll break the atomicity of the transaction. > We could also modify the _transaction._autocommit when calling UpdateSchema.__enter__ method, which indicates multiple updates is coming and we would like to avoid the autocommit. Something like: I feel like in this case, we can just get rid of `autocommit` entirely -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
