Fokko commented on code in PR #11588:
URL: https://github.com/apache/iceberg/pull/11588#discussion_r1916175700
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java:
##########
@@ -792,13 +794,14 @@ private static class Context implements Serializable {
Schema dataSchema,
SparkWriteConf writeConf,
LogicalWriteInfo info,
- SparkWriteRequirements writeRequirements) {
+ SparkWriteRequirements writeRequirements,
+ int formatVersion) {
this.dataSchema = dataSchema;
this.dataSparkType = info.schema();
this.dataFileFormat = writeConf.dataFileFormat();
this.targetDataFileSize = writeConf.targetDataFileSize();
this.deleteSparkType = info.rowIdSchema().get();
- this.deleteFileFormat = writeConf.deleteFileFormat();
+ this.deleteFileFormat = formatVersion >= 3 ? FileFormat.PUFFIN :
writeConf.deleteFileFormat();
Review Comment:
Isn't this redundant with the `useDVs` below? When going for `PUFFIN`, it
implies that it uses DVs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
