stevenzwu commented on pull request #1185: URL: https://github.com/apache/iceberg/pull/1185#issuecomment-683164685
nit: on class names IcebergStreamWriter -> IcebergWriter, because it also BoundedOneInput interface, which seems like a batch job. IcebergFilesCommitter -> IcebergCommitter. Iceberg only commits files. So including Files seems redundant. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
