RussellSpitzer commented on code in PR #12018:
URL: https://github.com/apache/iceberg/pull/12018#discussion_r1923867520
##########
format/spec.md:
##########
@@ -870,7 +870,7 @@ Table metadata consists of the following fields:
| _optional_ | _optional_ | _optional_ | **`statistics`** | A list
(optional) of [table statistics](#table-statistics).
|
| _optional_ | _optional_ | _optional_ | **`partition-statistics`** | A list
(optional) of [partition statistics](#partition-statistics).
|
| | | _optional_ | **`row-lineage`** | A
boolean, defaulting to false, setting whether or not to track the creation and
updates to rows in the table. See [Row Lineage](#row-lineage).
|
-| | | _optional_ | **`next-row-id`** | A value
higher than all assigned row IDs; the next snapshot's `first-row-id`. See [Row
Lineage](#row-lineage).
|
+| | | _optional_ | **`next-row-id`** | A
`long` higher than all assigned row IDs; the next snapshot's `first-row-id`.
See [Row Lineage](#row-lineage).
|
Review Comment:
Looks good to me, while we aren't actually putting an Iceberg type here I
think our definition of `long` in the spec as a signed 64 bit integer covers
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
