ggershinsky commented on code in PR #7770:
URL: https://github.com/apache/iceberg/pull/7770#discussion_r1924835904
##########
core/src/main/java/org/apache/iceberg/encryption/StandardEncryptionManager.java:
##########
@@ -81,22 +136,75 @@ private SecureRandom workerRNG() {
return lazyRNG;
}
+ /**
+ * @deprecated will be removed in 1.8.0; use {@link #currentSnapshotKeyId()}
instead.
+ */
+ @Deprecated
public ByteBuffer wrapKey(ByteBuffer secretKey) {
- if (kmsClient == null) {
+ if (transientState == null) {
throw new IllegalStateException(
"Cannot wrap key after called after serialization (missing KMS
client)");
}
- return kmsClient.wrapKey(secretKey, tableKeyId);
+ return transientState.kmsClient.wrapKey(secretKey, tableKeyId);
}
+ /**
+ * @deprecated will be removed in 1.8.0; use {@link #unwrapKey(String)}}
instead.
+ */
Review Comment:
Per the slack
[discussion](https://apache-iceberg.slack.com/archives/C02HPMR83A6/p1736970502471049?thread_ts=1736877132.783929&cid=C02HPMR83A6),
the target release is not yet finalized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
