RussellSpitzer commented on code in PR #12048:
URL: https://github.com/apache/iceberg/pull/12048#discussion_r1927198851
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java:
##########
@@ -739,23 +749,31 @@ private Table createTablePartitioned(int partitions, int
files, int numRecords)
}
private Table createTableUnpartitioned(int files, int numRecords) {
+ return createTableUnpartitioned(files, numRecords, 2);
Review Comment:
I would probably just keep a 1 off table creator for V3 Tables rather than
adding a new method which is parameterized solely for a single usage.
So we just inline
```java
Table table =
validationCatalog.createTable(
TableIdentifier.of("default", TABLE_NAME),
SCHEMA,
PartitionSpec.unpartitioned(),
tableProperties());
tableProperties(3));
writeRecords(table, files, numRecords);
```
In the V3 test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
