ebyhr commented on code in PR #12088:
URL: https://github.com/apache/iceberg/pull/12088#discussion_r1929470728
##########
core/src/main/java/org/apache/iceberg/FileMetadata.java:
##########
@@ -255,6 +255,8 @@ public DeleteFile build() {
if (format == FileFormat.PUFFIN) {
Preconditions.checkArgument(contentOffset != null, "Content offset is
required for DV");
Preconditions.checkArgument(contentSizeInBytes != null, "Content size
is required for DV");
+ Preconditions.checkArgument(
+ referencedDataFile != null, "Referenced data file is required for
DV");
Review Comment:
Thank you for your reviews! Added a test to TestDeleteFiles because there is
no dedicated test class for FileMetadata & DeleteFile. Let me know if there is
a better place or I should create a new test class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
