JoniKet commented on code in PR #1580:
URL: https://github.com/apache/iceberg-python/pull/1580#discussion_r1933478098
##########
tests/catalog/test_hive.py:
##########
@@ -204,6 +204,87 @@ def test_check_number_of_namespaces(table_schema_simple:
Schema) -> None:
catalog.create_table("table", schema=table_schema_simple)
[email protected]("hive2_compatible", [True, False])
+@patch("time.time", MagicMock(return_value=12345))
+def test_register_table(
Review Comment:
Integration test against real local Hivemetastore is better, I'll try to
implement this. Did not notice the great integration test coverage before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
