aokolnychyi commented on a change in pull request #1373:
URL: https://github.com/apache/iceberg/pull/1373#discussion_r481302113
##########
File path: core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java
##########
@@ -64,8 +65,8 @@ public Table createTable(
baseLocation = defaultWarehouseLocation(identifier);
}
- TableMetadata metadata = TableMetadata.newTableMetadata(
- schema, spec, baseLocation, properties == null ? Maps.newHashMap() :
properties);
+ Map<String, String> tableProps = properties != null ? properties :
ImmutableMap.of();
Review comment:
Yeah, I think that will be safe. Right now, we pass null for table
properties in overloaded methods so we must handle it explicitly. But nothing
prohibits a user from passing null for `spec` and `sortOrder` even though we
properly default them in overloaded methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
