RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1938246608
##########
core/src/test/java/org/apache/iceberg/TestTableMetadata.java:
##########
@@ -312,6 +341,8 @@ public void testBackwardCompat() throws Exception {
.isEqualTo(previousSnapshot.allManifests(ops.io()));
assertThat(metadata.previousFiles()).isEqualTo(expected.previousFiles());
assertThat(metadata.snapshot(previousSnapshotId).schemaId()).isNull();
+
assertThat(metadata.rowLineageEnabled()).isEqualTo(expected.rowLineageEnabled());
+ assertThat(metadata.nextRowId()).isEqualTo(expected.nextRowId());
Review Comment:
Not testJsonConversionWithRowLineage, testJsonConversion, it specifies these
fields and does a SERDE
```java
TableMetadata expected =
new TableMetadata(
null,
MAX_FORMAT_VERSION,
UUID.randomUUID().toString(),
TEST_LOCATION,
SEQ_NO,
System.currentTimeMillis(),
3,
7,
ImmutableList.of(TEST_SCHEMA, schema),
5,
ImmutableList.of(SPEC_5),
SPEC_5.lastAssignedFieldId(),
3,
ImmutableList.of(SORT_ORDER_3),
ImmutableMap.of("property", "value"),
currentSnapshotId,
Arrays.asList(previousSnapshot, currentSnapshot),
null,
snapshotLog,
ImmutableList.of(),
refs,
statisticsFiles,
partitionStatisticsFiles,
ImmutableList.of(),
true, // < Row lineage
40); // last-row-id
String asJson = TableMetadataParser.toJson(expected);
TableMetadata metadata = TableMetadataParser.fromJson(asJson);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
