RussellSpitzer commented on code in PR #12162:
URL: https://github.com/apache/iceberg/pull/12162#discussion_r1939346945
##########
format/spec.md:
##########
@@ -889,6 +892,9 @@ Table metadata consists of the following fields:
| _optional_ | _optional_ | _optional_ | **`partition-statistics`** | A list
(optional) of [partition statistics](#partition-statistics).
|
| | | _optional_ | **`row-lineage`** | A
boolean, defaulting to false, setting whether or not to track the creation and
updates to rows in the table. See [Row Lineage](#row-lineage).
|
| | | _optional_ | **`next-row-id`** | A
`long` higher than all assigned row IDs; the next snapshot's `first-row-id`.
See [Row Lineage](#row-lineage).
|
+| | | _optional_ | **`key-cache`** | A list
of encryption keys (key-id/key-wrap pairs), used to encrypt the manifest list
file key metadata. See [Snapshot](#key-metadata-key-id).
|
Review Comment:
I was wondering, if we really need multiple keys here. This would allow
folks to use old keys after a key rotation but is that something we really want
to enable? Shouldn't rotating a key wipe out the ability to use a new key and
require writing new manifest lists and replacing old ones?
I know we can get similar behavior with a Rotate + Expire, but is that a
real use case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
