amogh-jahagirdar commented on code in PR #12160: URL: https://github.com/apache/iceberg/pull/12160#discussion_r1939734307
########## spark/v3.5/spark-runtime/LICENSE: ########## @@ -379,14 +334,6 @@ License: http://www.apache.org/licenses/LICENSE-2.0 -------------------------------------------------------------------------------- -This binary artifact contains code from Presto. Review Comment: https://github.com/apache/iceberg/blob/main/spark/v3.5/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4#L19 So it seems like our Spark SQL extensions defined in the ANTLR grammar are an adaptation of OSS Spark and Presto grammars. I think we may want to keep this then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
