amogh-jahagirdar commented on code in PR #12167:
URL: https://github.com/apache/iceberg/pull/12167#discussion_r1940434089
##########
core/src/main/java/org/apache/iceberg/variants/VariantMetadata.java:
##########
@@ -34,4 +35,12 @@ public interface VariantMetadata extends Variants.Serialized
{
/** Returns the size of the metadata dictionary. */
int dictionarySize();
+
+ /** Returns the serialized size in bytes of this value. */
+ int sizeInBytes();
+
+ /**
+ * Writes this value to the buffer at the given offset, ignoring the
buffer's position and limit.
Review Comment:
Is it worth clarifying that this method should return how many bytes were
written to the buffer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
