fbocse commented on a change in pull request #1177:
URL: https://github.com/apache/iceberg/pull/1177#discussion_r482069642
##########
File path: core/src/main/java/org/apache/iceberg/SchemaUpdate.java
##########
@@ -308,6 +309,12 @@ public UpdateSchema moveAfter(String name, String
afterName) {
return this;
}
+ @Override
+ public UpdateSchema unionWithByFieldName(Schema newSchema) {
+ UnionByNameVisitor.visit(this, schema, newSchema);
Review comment:
@rdblue you're right, the implementation, while a bit more complex than
previous one feels less complicated.
##########
File path: core/src/main/java/org/apache/iceberg/SchemaUpdate.java
##########
@@ -308,6 +309,12 @@ public UpdateSchema moveAfter(String name, String
afterName) {
return this;
}
+ @Override
+ public UpdateSchema unionWithByFieldName(Schema newSchema) {
+ UnionByNameVisitor.visit(this, schema, newSchema);
Review comment:
@rdblue you're right, the implementation, while a bit more complex than
previous one, feels less complicated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
