zeroshade commented on code in PR #297:
URL: https://github.com/apache/iceberg-go/pull/297#discussion_r1949653000
##########
catalog/rest/rest.go:
##########
@@ -947,14 +1054,28 @@ func (r *Catalog) UpdateNamespaceProperties(ctx
context.Context, namespace table
return catalog.PropertiesUpdateSummary{}, err
}
+ ref := table.Identifier{}
+ if refStr := iceberg.GetRefFromContext(ctx); refStr != "" {
+ ref = catalog.ToIdentifier(refStr)
+ }
+
type payload struct {
- Remove []string `json:"removals"`
- Updates iceberg.Properties `json:"updates"`
+ PropertyUpdates iceberg.Properties `json:"propertyUpdates"`
+ PropertyRemovals []string
`json:"propertyRemovals,omitempty"`
}
Review Comment:
Isn't this change incompatible with the REST API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
