rdblue commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1955206561
##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -616,8 +616,8 @@ public T map(Types.MapType map, T keyResult, T valueResult)
{
return null;
}
- public T variant() {
- return null;
+ public T variant(Types.VariantType variant) {
+ throw new UnsupportedOperationException("Unsupported type: variant");
Review Comment:
This still need to be implemented by:
* `CreateMapping`
* `DescribeSchemaVisitor`
* `IdToOrcName` and other conversions
I think it's fine to implement the conversions later as part of Avro,
Parquet, and ORC work, but the common ones should probably be implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
