mattmartin14 commented on PR #1660: URL: https://github.com/apache/iceberg-python/pull/1660#issuecomment-2657806614
> Great work @mattmartin14 👏🏻 👏🏻 > > If I'm not mistaken this is your first PR merged in any open source project correct? > > Not a bad first feature! Mine was adding [array types for the Elasticsearch connector in Trino](https://trino.io/docs/current/connector/elasticsearch.html#array-types)...you know this because in the docs example, the `timestamp_field` is my birthday, the `array_int_field` is the [number to call Jenny](https://en.wikipedia.org/wiki/867-5309/Jenny), and the `int_field` is my lucky number. > > You also know this was acquired later by Presto since [they copied it to their docs](https://prestodb.github.io/docs/current/connector/elasticsearch.html#array-types) 😈. Correct, this was my first PR to open source; I'm 1/1 😁. And I learned a lot! I was unaware that you added the array type to trino. That is some cool stuff. Thanks again all, Matt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
