nastra commented on code in PR #11979:
URL: https://github.com/apache/iceberg/pull/11979#discussion_r1957818213
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -374,13 +375,17 @@ static HttpRequestInterceptor loadInterceptorDynamically(
return instance;
}
- static HttpClientConnectionManager configureConnectionManager(Map<String,
String> properties) {
+ static HttpClientConnectionManager configureConnectionManager(
+ Map<String, String> properties, TlsSocketStrategy tlsSocketStrategy) {
PoolingHttpClientConnectionManagerBuilder connectionManagerBuilder =
PoolingHttpClientConnectionManagerBuilder.create();
ConnectionConfig connectionConfig = configureConnectionConfig(properties);
if (connectionConfig != null) {
connectionManagerBuilder.setDefaultConnectionConfig(connectionConfig);
}
+ if (tlsSocketStrategy != null) {
+ connectionManagerBuilder.setTlsSocketStrategy(tlsSocketStrategy);
Review Comment:
typically stuff like this is all configured via the `properties` map.
Otherwise there isn't a way to configure this e.g. when using the REST catalog
with Spark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
