rdblue commented on code in PR #12139:
URL: https://github.com/apache/iceberg/pull/12139#discussion_r1960603787
##########
core/src/test/java/org/apache/iceberg/variants/VariantTestUtil.java:
##########
@@ -27,10 +29,55 @@
import java.util.stream.Collectors;
import java.util.stream.Stream;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
public class VariantTestUtil {
private VariantTestUtil() {}
+ public static void assertEqual(VariantMetadata expected, VariantMetadata
actual) {
+ assertThat(actual).isNotNull();
+ assertThat(expected).isNotNull();
+ assertThat(actual.dictionarySize())
+ .as("Dictionary size should match")
+ .isEqualTo(expected.dictionarySize());
+
+ for (int i = 0; i < expected.dictionarySize(); i += 1) {
+ assertThat(actual.get(i)).isEqualTo(expected.get(i));
+ }
+ }
+
+ public static void assertEqual(VariantValue expected, VariantValue actual) {
+ assertThat(actual).isNotNull();
+ assertThat(expected).isNotNull();
+ assertThat(actual.type()).as("Variant type should
match").isEqualTo(expected.type());
+
+ if (expected.type() == PhysicalType.OBJECT) {
+ VariantObject expectedObject = expected.asObject();
+ VariantObject actualObject = actual.asObject();
+ assertThat(actualObject.numFields())
+ .as("Variant object num fields should match")
+ .isEqualTo(expectedObject.numFields());
+ for (String fieldName : expectedObject.fieldNames()) {
+ assertEqual(expectedObject.get(fieldName),
actualObject.get(fieldName));
+ }
+
Review Comment:
This is fine since it helps readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
