sungwy commented on code in PR #1669:
URL: https://github.com/apache/iceberg-python/pull/1669#discussion_r1960579776
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1655,19 +1646,16 @@ class
ArrowProjectionVisitor(SchemaWithPartnerVisitor[pa.Array, Optional[pa.Arra
_file_schema: Schema
_include_field_ids: bool
_downcast_ns_timestamp_to_us: bool
- _use_large_types: bool
def __init__(
self,
file_schema: Schema,
downcast_ns_timestamp_to_us: bool = False,
include_field_ids: bool = False,
- use_large_types: bool = True,
Review Comment:
I've always dreaded the process of updating our code base that does not have
a properly defined list of public classes 😞
But would this change require a deprecation notice first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
