nastra commented on code in PR #12320:
URL: https://github.com/apache/iceberg/pull/12320#discussion_r1961811334
##########
mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergSplit.java:
##########
@@ -73,7 +74,10 @@ public String[] getLocations() {
// getLocations() won't be accurate when called on worker nodes and will
always return "*"
if (locations == null && conf != null) {
boolean localityPreferred = conf.getBoolean(InputFormatConfig.LOCALITY,
false);
- locations = localityPreferred ? Util.blockLocations(task, conf) :
ANYWHERE.clone();
+ locations =
+ localityPreferred
+ ? Util.blockLocations((ScanTaskGroup<FileScanTask>) task, conf)
Review Comment:
I believe this change isn't necessary and it should also work without the
cast
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
