danielcweeks commented on code in PR #12270:
URL: https://github.com/apache/iceberg/pull/12270#discussion_r1962494198
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RemoveDanglingDeletesSparkAction.java:
##########
@@ -156,7 +162,12 @@ private List<DeleteFile> findDanglingDeletes() {
.or(
col("data_file.content")
.equalTo("2")
-
.and(col("sequence_number").$less$eq(col("min_data_sequence_number"))));
+
.and(col("sequence_number").$less$eq(col("min_data_sequence_number"))))
+ // dvs pointing to non-existing data files
+ .or(
+ col("data_file.file_format")
+ .equalTo(FileFormat.PUFFIN.name())
Review Comment:
I think @singhpk234 is pointing out the potential for scheme mismatch. The
handling done in orphan files is
[here](https://github.com/apache/iceberg/pull/4652/files#diff-7c30ffadb3245d8506d3056b9e671be2400fd1149b886946ddc404089c406844R158)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
