RussellSpitzer commented on code in PR #12228:
URL: https://github.com/apache/iceberg/pull/12228#discussion_r1963827384


##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -2871,6 +2872,33 @@ public void testRegisterExistingTable() {
     assertThat(catalog.dropTable(identifier)).isTrue();
   }
 
+  @Test
+  public void testRegisterAndOverwriteExistingTable() {
+    C catalog = catalog();

Review Comment:
   Are we just adding a bucket to test the change? Why not just use the table 
UUID? I feel like we should be able to just
   
   Make Table 1
   Make Table 2
   Register overwrite Table1 with Table2
   Check that metadata table1 matches table 2?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to