rdblue commented on a change in pull request #1435:
URL: https://github.com/apache/iceberg/pull/1435#discussion_r485981666
##########
File path: flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java
##########
@@ -179,14 +185,17 @@ public boolean databaseExists(String databaseName) throws
CatalogException {
@Override
public void createDatabase(String name, CatalogDatabase database, boolean
ignoreIfExists)
throws DatabaseAlreadyExistException, CatalogException {
+ createDatabase(name, mergeComment(database.getProperties(),
database.getComment()), ignoreIfExists);
+ }
+
+ private void createDatabase(String databaseName, Map<String, String>
comments, boolean ignoreIfExists)
+ throws DatabaseAlreadyExistException, CatalogException {
if (asNamespaceCatalog != null) {
try {
- asNamespaceCatalog.createNamespace(
- toNamespace(name),
- mergeComment(database.getProperties(), database.getComment()));
+ asNamespaceCatalog.createNamespace(toNamespace(databaseName),
comments);
Review comment:
Should this be `metadata` instead of `comments`? I think that it could
contain other properties, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
