wangmiao1981 commented on a change in pull request #1436:
URL: https://github.com/apache/iceberg/pull/1436#discussion_r486064429



##########
File path: core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java
##########
@@ -81,6 +81,7 @@ public Transaction newReplaceTableTransaction(
       String location,
       Map<String, String> properties,
       boolean orCreate) {
+    Preconditions.checkArgument(isValidIdentifier(identifier), "Invalid table 
identifier: %s", identifier);

Review comment:
       Yes. Missed that. this line is not needed. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to