gaborkaszab commented on code in PR #12194:
URL: https://github.com/apache/iceberg/pull/12194#discussion_r1967724569
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -2221,23 +2224,26 @@ public void testPaginationForListTables(int
numberOfItems) {
eq(RESTCatalogAdapter.Route.LIST_TABLES),
eq(ImmutableMap.of("pageToken", "", "pageSize", "10", "namespace",
namespaceName)),
any(),
- eq(ListTablesResponse.class));
+ eq(ListTablesResponse.class),
+ any());
// verify second request with updated pageToken
Mockito.verify(adapter)
.handleRequest(
eq(RESTCatalogAdapter.Route.LIST_TABLES),
eq(ImmutableMap.of("pageToken", "10", "pageSize", "10",
"namespace", namespaceName)),
any(),
- eq(ListTablesResponse.class));
+ eq(ListTablesResponse.class),
+ any());
// verify third request with update pageToken
Mockito.verify(adapter)
.handleRequest(
eq(RESTCatalogAdapter.Route.LIST_TABLES),
eq(ImmutableMap.of("pageToken", "20", "pageSize", "10",
"namespace", namespaceName)),
any(),
- eq(ListTablesResponse.class));
+ eq(ListTablesResponse.class),
+ any());
Review Comment:
Currently RESTCatalogAdapter.handleRequest() doesn't populate the
responseHeaders param. As a follow-up PR I'm planning to add functionality to
RESTCatalogAdapter so that it can take care of the header and return codes
required for freshness aware loading (like the 'if-None-Match' input header,
'ETag' output header and the 304 response).
This current PR is just a boilerplate code to have the request and response
headers available in the get-post requests for a later use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
