abstractdog commented on code in PR #12427:
URL: https://github.com/apache/iceberg/pull/12427#discussion_r1975827553


##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -197,7 +198,7 @@ protected String targetBranch() {
   }
 
   protected ExecutorService workerPool() {
-    return this.workerPool;
+    return 
Optional.ofNullable(workerPool).orElseGet(ThreadPools::getWorkerPool);

Review Comment:
   btw, looks like I forgot to replace with workerPool(), let me do quickly
   FIXED in 
https://github.com/apache/iceberg/pull/12427/commits/e50b767d5885b994aa935c1d6ec70dc7f0d9fb5f



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to