rdblue commented on code in PR #12496:
URL: https://github.com/apache/iceberg/pull/12496#discussion_r1988118605
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java:
##########
@@ -142,7 +144,8 @@ public void add(T value) {
public Metrics metrics() {
Preconditions.checkState(closed, "Cannot return metrics for unclosed
writer");
if (writer != null) {
- return ParquetUtil.footerMetrics(writer.getFooter(), model.metrics(),
metricsConfig);
+ return ParquetMetrics.metrics(
+ schema, parquetSchema, metricsConfig, writer.getFooter(),
model.metrics());
Review Comment:
Schema is currently required because there is no annotation for variants in
the Parquet schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
