rdblue commented on a change in pull request #1423:
URL: https://github.com/apache/iceberg/pull/1423#discussion_r487593188
##########
File path: build.gradle
##########
@@ -299,6 +299,67 @@ project(':iceberg-flink') {
}
}
+project(':iceberg-flink-runtime') {
+ apply plugin: 'com.github.johnrengelman.shadow'
+
+ tasks.jar.dependsOn tasks.shadowJar
+
+ configurations {
+ compile {
+ exclude group: 'org.apache.flink'
+ // included in Flink
+ exclude group: 'org.slf4j'
+ exclude group: 'org.apache.commons'
+ exclude group: 'commons-pool'
+ exclude group: 'commons-codec'
+ exclude group: 'org.xerial.snappy'
+ exclude group: 'javax.xml.bind'
+ exclude group: 'javax.annotation'
+ }
+ }
+
+ dependencies {
+ compile project(':iceberg-flink')
+ }
+
+ shadowJar {
+ configurations = [project.configurations.compile]
+
+ zip64 true
+
+ // include the LICENSE and NOTICE files for the shaded Jar
+ from(projectDir) {
+ include 'LICENSE'
+ include 'NOTICE'
+ }
+
+ // Relocate dependencies to avoid conflicts
+ relocate 'com.google', 'org.apache.iceberg.shaded.com.google'
+ relocate 'com.fasterxml', 'org.apache.iceberg.shaded.com.fasterxml'
+ relocate 'org.checkerframework',
'org.apache.iceberg.shaded.org.checkerframework'
+ relocate 'org.apache.avro', 'org.apache.iceberg.shaded.org.apache.avro'
+ relocate 'avro.shaded', 'org.apache.iceberg.shaded.org.apache.avro.shaded'
+ relocate 'com.thoughtworks.paranamer',
'org.apache.iceberg.shaded.com.thoughtworks.paranamer'
+ relocate 'org.apache.parquet',
'org.apache.iceberg.shaded.org.apache.parquet'
+ relocate 'shaded.parquet',
'org.apache.iceberg.shaded.org.apache.parquet.shaded'
+ // relocate Avro's jackson dependency to share parquet-jackson locations
+ relocate 'org.codehaus.jackson',
'org.apache.iceberg.shaded.org.apache.parquet.shaded.org.codehaus.jackson'
+ relocate 'org.apache.orc', 'org.apache.iceberg.shaded.org.apache.orc'
+ relocate 'io.airlift', 'org.apache.iceberg.shaded.io.airlift'
+ // relocate Arrow and related deps to shade Iceberg specific version
+ relocate 'io.netty.buffer', 'org.apache.iceberg.shaded.io.netty.buffer'
+ relocate 'org.apache.arrow', 'org.apache.iceberg.shaded.org.apache.arrow'
+ relocate 'com.carrotsearch', 'org.apache.iceberg.shaded.com.carrotsearch'
Review comment:
I don't think these 3 (Netty, Arrow, and Carrotsearch) need to be
relocated since they should not be included in the Jar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
