bryanck commented on code in PR #11780:
URL: https://github.com/apache/iceberg/pull/11780#discussion_r1995663948
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkConfig.java:
##########
@@ -211,6 +214,12 @@ private static ConfigDef newConfigDef() {
Runtime.getRuntime().availableProcessors() * 2,
Importance.MEDIUM,
"Coordinator threads to use for table commits, default is (cores *
2)");
+ configDef.define(
+ TRANSACTIONAL_PREFIX_PROP,
+ ConfigDef.Type.STRING,
+ DEFAULT_TRANSACTIONAL_PREFIX,
Review Comment:
I feel we should use `null` as the default, to be consistent with other
configs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
