kbendick opened a new issue #1453: URL: https://github.com/apache/iceberg/issues/1453
After some back and forth between myself and @rdblue on this PR for improving the release script to detect the archive list automatically, https://github.com/apache/iceberg/pull/1227/files, we've come up with some working solutons. However, in my opinion, the working solutions that I've offered are potentially a little too cute (read: hacky). Having looked into it further, the proper way to exclude certain files from a git archive is to use the `.gitattributes` file and then mark the given files to be excluded from a release as `export-ignore`. Since I don't have the ability to push to that branch, I'm going to add a .gitattributes file which has the excludes in it. This should simplify the several lines of shell scripts (with many pipes) into one simple `git archive` command that simply archives based off of a tag. That tag is already generated, pushed to github, and available for reference in the release script. This way of doing it should make the release script much more maintainable, while also making the release process much more standardized for release engineers who are likely aware of concepts like those found in `.gitattributes. I will open a PR as a POC for the appropriate .gitattributes file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
