zeroshade commented on code in PR #339:
URL: https://github.com/apache/iceberg-go/pull/339#discussion_r2002171446
##########
table/transaction.go:
##########
@@ -178,14 +179,39 @@ func (t *Transaction) AddFiles(files []string,
snapshotProps iceberg.Properties,
return t.apply(updates, reqs)
}
-func (t *Transaction) StagedTable() (*Table, error) {
+func (t *Transaction) Scan(opts ...ScanOption) (*Scan, error) {
updatedMeta, err := t.meta.Build()
if err != nil {
return nil, err
}
- return New(t.tbl.identifier, updatedMeta,
- updatedMeta.Location(), t.tbl.fs, t.tbl.cat), nil
+ s := &Scan{
+ metadata: updatedMeta,
+ io: t.tbl.fs,
+ rowFilter: iceberg.AlwaysTrue{},
+ selectedFields: []string{"*"},
+ caseSensitive: true,
+ limit: ScanNoLimit,
Review Comment:
All of them should be available via ScanOption already. These are just the
defaults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
