pvary commented on code in PR #12567:
URL: https://github.com/apache/iceberg/pull/12567#discussion_r2003455823


##########
orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java:
##########
@@ -82,6 +82,24 @@ public TypeDescription type() {
 
   static final String ICEBERG_FIELD_LENGTH = "iceberg.length";
 
+  /**
+   * The name of the ORC {@link TypeDescription} attribute indicating the 
Iceberg timestamp unit.

Review Comment:
   nit: the two descriptions are mixed up (`iceberg.timestamp-unit`, 
`iceberg.struct-type`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to