Fokko commented on code in PR #1772:
URL: https://github.com/apache/iceberg-python/pull/1772#discussion_r2005832177
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -251,6 +253,13 @@ def _commit(self) -> UpdatesAndRequirements:
)
location_provider = self._transaction._table.location_provider()
manifest_list_file_path =
location_provider.new_metadata_location(file_name)
+
+ # get current snapshot id and starting snapshot id, and validate that
there are no conflicts
+ if self._transaction._table.__class__.__name__ != "StagedTable":
Review Comment:
How about importing it in the function? That should break the cyclical
import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
