rdblue commented on pull request #1452: URL: https://github.com/apache/iceberg/pull/1452#issuecomment-692855087
After thinking about this a little more, I think we should remove the other constructor. The problem with it is that it doesn't copy the incoming array, so the contents of the split could be modified afterwards. We could add `Arrays.copyOf` to fix it, but since this constructor is unused, we should just remove it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
