nastra commented on code in PR #12632:
URL: https://github.com/apache/iceberg/pull/12632#discussion_r2009919021
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java:
##########
@@ -723,10 +724,43 @@ public void testSchemaEvolution() throws Exception {
assertEquals("Rows must match", expectedRecords, actualRecords);
}
+ @TestTemplate
+ public void testSnapshotProperty() throws Exception {
+ Table table = createTableUnpartitioned(2, SCALE);
+ List<DataFile> dataFiles = TestHelpers.dataFiles(table);
+ writePosDeletesForFiles(table, 2, DELETES_SCALE, dataFiles);
+ assertThat(dataFiles).hasSize(2);
+
+ List<DeleteFile> deleteFiles = deleteFiles(table);
+ assertThat(deleteFiles).hasSize(2);
+
+ Result ignored =
+ SparkActions.get(spark)
+ .rewritePositionDeletes(table)
+ .snapshotProperty("key", "value")
+ .option(SizeBasedFileRewriter.REWRITE_ALL, "true")
+ .execute();
+ assertThat(table.currentSnapshot().summary())
+ .containsAllEntriesOf(ImmutableMap.of("key", "value"));
+
+ // make sure internal produced properties are not lost
+ String[] commitMetricsKeys =
+ new String[] {
+ SnapshotSummary.ADDED_DELETE_FILES_PROP,
+ SnapshotSummary.ADDED_POS_DELETES_PROP,
+ SnapshotSummary.CHANGED_PARTITION_COUNT_PROP,
+ SnapshotSummary.REMOVED_DELETE_FILES_PROP,
+ SnapshotSummary.REMOVED_POS_DELETES_PROP,
+ SnapshotSummary.TOTAL_DATA_FILES_PROP,
+ SnapshotSummary.TOTAL_DELETE_FILES_PROP,
+ };
+
assertThat(table.currentSnapshot().summary()).containsKeys(commitMetricsKeys);
+ }
+
@TestTemplate
public void testRewriteManyColumns() throws Exception {
List<Types.NestedField> fields =
- Lists.newArrayList(Types.NestedField.optional(0, "id",
Types.LongType.get()));
+ Lists.newArrayList(Types.NestedField.required(0, "id",
Types.LongType.get()));
Review Comment:
aligns the code with Spark 3.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
