pvary commented on code in PR #12637:
URL: https://github.com/apache/iceberg/pull/12637#discussion_r2012235572
##########
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##########
@@ -310,7 +310,7 @@ protected CommitStatus checkCommitStatus(String
newMetadataLocation, TableMetada
* @return true if the new metadata location is the current metadata
location or present within
* previous metadata files.
*/
- private boolean checkCurrentMetadataLocation(String newMetadataLocation) {
+ protected boolean checkCurrentMetadataLocation(String newMetadataLocation) {
Review Comment:
I'm not sure which is better:
1. Making this method `protected`, or
2. Creating a new `checkCommitStatusStrict(String newMetadataLocation,
TableMetadata config)` protected method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
