nastra commented on code in PR #12593:
URL: https://github.com/apache/iceberg/pull/12593#discussion_r2012469740
##########
core/src/main/java/org/apache/iceberg/TableMetadataParser.java:
##########
@@ -465,12 +463,10 @@ public static TableMetadata fromJson(String
metadataLocation, JsonNode node) {
currentSnapshotId = -1L;
}
- Boolean rowLineage = JsonUtil.getBoolOrNull(ROW_LINEAGE, node);
long lastRowId;
- if (rowLineage != null && rowLineage) {
+ if (formatVersion >= 3) {
Review Comment:
nit: we might as well initialize the `lastRowId` in a one-liner:
`long lastRowId = formatVersion >= 3 ? JsonUtil.getLong(NEXT_ROW_ID, node) :
TableMetadata.INITIAL_ROW_ID;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
