danielcweeks commented on code in PR #12638:
URL: https://github.com/apache/iceberg/pull/12638#discussion_r2017675636
##########
gcp/src/main/java/org/apache/iceberg/gcp/gcs/OAuth2RefreshCredentialsHandler.java:
##########
@@ -49,6 +53,11 @@ private OAuth2RefreshCredentialsHandler(Map<String, String>
properties) {
Preconditions.checkArgument(
null !=
properties.get(GCPProperties.GCS_OAUTH2_REFRESH_CREDENTIALS_ENDPOINT),
"Invalid credentials endpoint: null");
+ Preconditions.checkArgument(
+ null != properties.get(CatalogProperties.URI), "Invalid catalog
endpoint: null");
+ this.credentialsEndpoint =
Review Comment:
Why aren't we doing the same thing here that we do in ADLS?
```java
RESTUtil.resolveEndpoint(
properties.get(CatalogProperties.URI),
properties.get(ADLS_REFRESH_CREDENTIALS_ENDPOINT));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
