kevinjqliu commented on code in PR #350:
URL: https://github.com/apache/iceberg-go/pull/350#discussion_r2006131459
##########
table/metadata.go:
##########
@@ -1095,7 +1095,7 @@ func (c *commonMetadata) Version() int { return
c.FormatVersion }
type metadataV1 struct {
Schema *iceberg.Schema `json:"schema"`
Review Comment:
i thought `omitempty` was a way to prevent serializing the field as
`"null"`. its still possible for someone to set use the library and set
`schema` to `null` and then serialize it to `"null"`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
